Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to shell completions #1208

Closed
wants to merge 1 commit into from

Conversation

iloveitaly
Copy link
Contributor

docs link to zsh shell completions.

@coffee-cup coffee-cup added the release/skip Author no release label Oct 26, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Nov 6, 2024
@iloveitaly
Copy link
Contributor Author

Friendly reminder about this pull request! Let me know if anything else is needed here.

@brody192
Copy link
Contributor

brody192 commented Nov 6, 2024

Hmmm, I don't think we are too keen about linking out to a repo from a 3rd party.

@iloveitaly
Copy link
Contributor Author

Makes sense. Would you consider bundling this into the nixpacks installation?

@github-actions github-actions bot removed the stale The pull request is stale label Nov 7, 2024
@coffee-cup
Copy link
Contributor

Agreed with @brody192. Would definitely be into adding the completions into this repo!

@iloveitaly
Copy link
Contributor Author

@coffee-cup do you know where the brew installation logic is? Not sure the best way to package completions into this repo / build system. Point me in the right direction and I'll attempt to make the time for it.

@coffee-cup
Copy link
Contributor

@coffee-cup
Copy link
Contributor

Going to close this out because I just don't think we can link to an external repo we don't control for security purposes. Appreciate the PR though!

@coffee-cup coffee-cup closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/skip Author no release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants